Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on Serial NativeRead #722

Merged

Conversation

josesimoes
Copy link
Member

Description

  • The call now returns without further delay if there are enough bytes in the buffer to satisfy the request

Motivation and Context

  • Fixes issue with read not returning until timeout elapsed, no matter if there were enough bytes available for read

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- The call now returns without further delay if there are enough bytes in the buffer to satisfy the request

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jun 4, 2018
@nfbot
Copy link
Member

nfbot commented Jun 4, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit dd6a5fc into nanoframework:develop Jun 4, 2018
@josesimoes josesimoes deleted the improvement-on-serial-NativeRead branch June 4, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants