Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format specifier for double printf #743

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

josesimoes
Copy link
Member

Description

  • The format specifier when calling the printf wasn't correct.

Motivation and Context

  • This fix makes the double tostring ouput to match the standard .NET

How Has This Been Tested?

Test code

 double hiTemp = 62.1;
Console.WriteLine("hiTemp: " + hiTemp.ToString());

Current output

hiTemp: 62.100000000000001

Output after this fix (matching the output from the standard .NET)

hiTemp: 62.1

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Jun 13, 2018
@nfbot
Copy link
Member

nfbot commented Jun 13, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 079d7e4 into nanoframework:develop Jun 13, 2018
@josesimoes josesimoes deleted the fix-double-tostring branch June 13, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants