Work on build with support for SP or DP floating point #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josesimoes
added
Type: enhancement
Area: Config-and-Build
Area: Common libs
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
force-pushed
the
work-sp-dp-math
branch
from
9d8b0ef to
604f3da
Compare
- Add CMake option DP_FLOATINGPOINT to enable DP support (default it SP) - Add new Math functions: Abs, Max and Min - Rework Math classes declaration - Rework implementation to add support for new overloaded Math methods with float and double parameters - Update declaration of mscorlib native assembly to match managed one - Clean up native double header with unused defines for Renesas compiler ** HACK REQUIRED FOR ESP32 in Math::Truncate ** Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
force-pushed
the
work-sp-dp-math
branch
from
604f3da to
fada21b
Compare
josesimoes
commented
Jun 15, 2018
| float Math::Truncate( float d, float& integralValue ) | ||
| { | ||
| integralValue = 0; | ||
| float retVal = modf(d, (double*)&integralValue); |
There was a problem hiding this comment.
@AdrianSoundy I had to force a cast here to (double*) otherwise the build fails...
Does this means that ESP32 can use the single-precision library? Or is it something that could be missing in the compiler switches?
BTW, is the compiler set to use the FPU?
There was a problem hiding this comment.
I meant can't use the sp lib...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions