Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code to remove compiler warning #749

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

sharmavishnu
Copy link
Contributor

@sharmavishnu sharmavishnu commented Jun 16, 2018

Description

Added initialization for Monitor_Ping_Reply and fine tuned conditional statement in method Monitor_Ping. If a build is done with NF_WP_IMPLEMENTS_CRC32 = ON, the compilation was failing (if you set treat warnings as errors) because of incorrect initialization of Monitor_Ping_Reply.

Motivation and Context

  • Fixes compiler warning/error (if treat warning as error is set) due to incorrect initialization

How Has This Been Tested?

Tested build on a 64-bit Windows 10 OS.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sharmavishnu

Added initialization for Monitor_Ping_Reply and fine tuned conditional statement in method Monitor_Ping. If a build is done with NF_WP_IMPLEMENTS_CRC32 = ON, the compilation was failing (if you set treat warnings as errors) because of incorrect initialization of Monitor_Ping_Reply.
@nfbot
Copy link
Member

nfbot commented Jun 16, 2018

Hi @sharmavishnu,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@sharmavishnu
Copy link
Contributor Author

Submitted for review and final merge of code that fixes compiler warning/error due to missing initialization.

@sharmavishnu sharmavishnu reopened this Jun 16, 2018
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jun 16, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@josesimoes josesimoes merged commit 567c54b into nanoframework:develop Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants