Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Guid and random for Esp32 #804

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Add new Guid and random for Esp32 #804

merged 2 commits into from
Jul 25, 2018

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jul 25, 2018

Description

Add the new guid implementation based on the version 4 guid ( random )
See : http://guid.one/guid/make
Added the targetRandom.cpp for Esp32 so random numbers use the true random numbers
Well random seed if no wireless and True random numbers if Wireless initialised.

Motivation and Context

How Has This Been Tested?

Print out 20 x GUIDs and all different
Restart board
Print out 20 x GUIDs and all different again from first lot

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Jul 25, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets Area: Common libs Everything related with common libraries labels Jul 25, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit 58f6cf5 into nanoframework:develop Jul 25, 2018
@AdrianSoundy AdrianSoundy deleted the develop-guid-random branch July 25, 2018 21:57
josesimoes pushed a commit that referenced this pull request Jul 27, 2018
- Also added target random implementation for ESP32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement native code helper to generate a new Guid
3 participants