Fix number conversion

[josesimoes]

Description

• Remove unnecessary call to function removing trailing zeros

Motivation and Context

• Fixes Floats / doubles are not formatted correctly Home#381

How Has This Been Tested?

• ToString sample app from samples repo

output from desktop console app

*************************
* plain ToString() test *
*************************
integer '0': 0
integer '12345': 12345
integer '-12345': -12345
double '123.45': 123.45
float '456.78F': 456.78
long '85': 85
long '1234567': 1234567
ulong '200': 200

**********************
* ToString("X") test *
**********************
integer '0': 0
integer '12345': 3039
integer '-12345': FFFFCFC7
long '85': 55
long '1234567': 12D687
ulong '200': C8

**********************
* ToString("X2") test *
**********************
integer '0': 00
integer '12345': 3039
integer '-12345': FFFFCFC7
long '85': 55
long '1234567': 12D687
ulong '200': C8

**********************
* ToString("X0") test *
**********************
integer '0': 0
integer '12345': 3039
integer '-12345': FFFFCFC7
long '85': 55
long '1234567': 12D687
ulong '200': C8

**********************
* ToString("N0") test *
**********************
integer '0': 0
integer '12345': 12,345
integer '-12345': -12,345
long '85': 85
long '1234567': 1,234,567
ulong '200': 200
double '123.45': 123
double '-1898300.1987': -1,898,300
float '456.78F': 457

**********************
* ToString("N") test *
**********************
integer '0': 0.00
integer '12345': 12,345.00
integer '-12345': -12,345.00
long '85': 85.00
long '1234567': 1,234,567.00
ulong '200': 200.00
double '123.45': 123.45
double '-1898300.1987': -1,898,300.20
float '456.78F': 456.78

**********************
* ToString("N3") test *
**********************
integer '0': 0.000
integer '12345': 12,345.000
integer '-12345': -12,345.000
long '85': 85.000
long '1234567': 1,234,567.000
ulong '200': 200.000
double '123.45': 123.450
double '-1898300.1987': -1,898,300.199
float '456.78F': 456.780

output from nanoFramework device

*************************
* plain ToString() test *
*************************
integer '0': 0
integer '12345': 12345
integer '-12345': -12345
double '123.45': 123.450000000000002
float '456.78F': 456.779998779
long '85': 85
long '1234567': 1234567
ulong '200': 200

**********************
* ToString("X") test *
**********************
integer '0': 00
integer '12345': 3039
integer '-12345': FFFFCFC7
long '85': 55
long '1234567': 12D687
ulong '200': C8

**********************
* ToString("X2") test *
**********************
integer '0': 00
integer '12345': 3039
integer '-12345': FFFFCFC7
long '85': 55
long '1234567': 12D687
ulong '200': C8

**********************
* ToString("X0") test *
**********************
integer '0': 0
integer '12345': 3039
integer '-12345': FFFFCFC7
long '85': 55
long '1234567': 12D687
ulong '200': C8

**********************
* ToString("N0") test *
**********************
integer '0': 0
integer '12345': 12,345
integer '-12345': -12,345
long '85': 85
long '1234567': 1,234,567
ulong '200': 200
double '123.45': 123
double '-1898300.1987': -1,898,300
float '456.78F': 457

**********************
* ToString("N") test *
**********************
integer '0': 00.00
integer '12345': 12,345.00
integer '-12345': -12,345.00
long '85': 85.00
long '1234567': 1,234,567.00
ulong '200': 200.00
double '123.45': 123.45
double '-1898300.1987': -1,898,300.20
float '456.78F': 456.78

**********************
* ToString("N3") test *
**********************
integer '0': 000.000
integer '12345': 12,345.000
integer '-12345': -12,345.000
long '85': 850.000
long '1234567': 1,234,567.000
ulong '200': 200.000
double '123.45': 123.450
double '-1898300.1987': -1,898,300.199
float '456.78F': 456.780

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

[nfbot]

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉