Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config changes #818

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Config changes #818

merged 1 commit into from
Aug 22, 2018

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Aug 22, 2018 •
edited by josesimoes
Loading

Fixes to Configuration mangement

Fixes nanoframework/Home#377

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Aug 22, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: bug Series: ESP32 Everything related specifically with ESP32 series targets labels Aug 22, 2018
@josesimoes josesimoes merged commit db25baf into nanoframework:develop-network Aug 22, 2018
@AdrianSoundy AdrianSoundy deleted the network-config branch August 22, 2018 11:10
@josesimoes josesimoes mentioned this pull request Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes