Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework system math implementation #823

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Rework system math implementation #823

merged 1 commit into from
Aug 24, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Remove math abstraction layer
  • Replace previous math calls with direct calls to math lib

Motivation and Context

  • In this day and age the math library from GCC, newlib (or any decent compiler!) provide all the basic functions, so there is no need to keep using this legacy abstraction layer.
  • Fixes Math.Round(float) hangs the board Home#385

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Rework system math implementation
ed56e90 
- Remove math abstraction layer
- Replace previous math calls with direct calls to math lib

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Type: enhancement Area: Common libs Everything related with common libraries labels Aug 24, 2018
@nfbot
Copy link
Member

nfbot commented Aug 24, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit b6c0fec into nanoframework:develop Aug 24, 2018
@josesimoes josesimoes deleted the rework-system-math branch August 24, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Math.Round(float) hangs the board
2 participants
@josesimoes @nfbot