Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented WatchChar in ESP32 #831

Merged
merged 7 commits into from
Aug 28, 2018
Merged

Implemented WatchChar in ESP32 #831

merged 7 commits into from
Aug 28, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

@MatthiasJentsch MatthiasJentsch commented Aug 28, 2018

Description

Implemented WatchChar in ESP32 for the serial communication. Added also the events for watchchar and chars for the serial communication. The events are only fired if an event handler is attached.

Motivation and Context

How Has This Been Tested?

Tested with SerialCommunication example. Set watchchar and see that the watchchar event has arrived in the C# program is the char is in the input stream. Also if no one read the chars from the input stream the chars event is raised.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

…argets/FreeRTOS/ESP32_DevKitC/nanoCLR/Windows.Devices.SerialCommunication/win_dev_serial_native_Windows_Devices_SerialCommunication_SerialDevice.cpp

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
Corrected NativeStore: Don't wait 1 second. Wait writeTimeout timespan

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
…ble_pattern_det_intr

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
… UART1 and UART2 but externally it uses port index 1, 2 and 3 for COM1, COM2 and COM3

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
@nfbot
Copy link
Member

nfbot commented Aug 28, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Series: ESP32 Everything related specifically with ESP32 series targets labels Aug 28, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🥇

@MatthiasJentsch MatthiasJentsch merged commit 306cb32 into nanoframework:develop Aug 28, 2018
@MatthiasJentsch MatthiasJentsch deleted the watchchar branch August 28, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchChar is not implemented in ESP32
3 participants