Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single precision Truncate___STATIC__R4__R4 #836

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Fix single precision Truncate___STATIC__R4__R4 #836

merged 1 commit into from
Sep 3, 2018

Conversation

NemesisXB
Copy link
Contributor

@NemesisXB NemesisXB commented Sep 3, 2018 •
edited by josesimoes
Loading

Description

Fix SP Truncate in native corlib math

Motivation and Context

The single precision Truncate function in corlib math incorrectly returned the fractional part instead of the integral part.

How Has This Been Tested?

Reproduced bug using STM32F429I-Discovery board.
Updated the CLR and tested with same test code, this time getting the expected result

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: NemesisXB 485436+NemesisXB@users.noreply.github.com

@NemesisXB
Fix single precision Truncate___STATIC__R4__R4
9f86c7c 
The single precision Truncate function in corlib math incorrectly returned the fractional part instead of the integral part.

Fix (issue nanoframework#392 reported in home repo)

Signed-off-by: NemesisXB <485436+NemesisXB@users.noreply.github.com>
@nfbot
Copy link
Member

nfbot commented Sep 3, 2018

Hi @NemesisXB,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Sep 3, 2018
@josesimoes josesimoes merged commit beccd9b into nanoframework:develop Sep 3, 2018
@NemesisXB NemesisXB deleted the home-issue-392 branch September 14, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Math.Truncate should return the integral part
4 participants
@NemesisXB @nfbot @CLAassistant @josesimoes