Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Math.Round #839

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Fix Math.Round #839

merged 1 commit into from
Sep 4, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Revert changes in Math.Round code.

Motivation and Context

How Has This Been Tested?

  • Test app following reported issue
var x = Math.Round(-8.5f);
Console.WriteLine("Math.Round(-8.5f): " + x.ToString());

x = Math.Round(50.5f);
Console.WriteLine("Math.Round(50.5f): " + x.ToString());

Screenshots

Console output from VS

Math.Round(-8.5f): -8.000000000
Math.Round(50.5f): 50.000000000

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Sep 4, 2018
@nfbot
Copy link
Member

nfbot commented Sep 4, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit bd40448 into nanoframework:develop Sep 4, 2018
@josesimoes josesimoes deleted the fix-391 branch September 4, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math.Round should round to even number if fractional is midpoint
2 participants