Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for double.ToString() and float.ToString() #841

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Fix for double.ToString() and float.ToString() #841

merged 2 commits into from
Sep 6, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

Description

Added the function nf_RemovePrependedZeros and call it after sprintf to remove the prepended zeros. That's only done for format "G"/"G0"

Motivation and Context

How Has This Been Tested?

Tested with C# program. (47.0).ToString() returns now "47" and (11.0f).ToString() returns now "11".

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

… as described

Added the function nf_RemovePrependedZeros and call it after sprintf to remove the prepended zeros. That's only done for format "G"/"G0"

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
@nfbot
Copy link
Member

nfbot commented Sep 5, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Sep 5, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew that function would be useful! 😉

@josesimoes josesimoes changed the title Fix for: double.ToString() and float.ToString() not working as described Fix for double.ToString() and float.ToString() Sep 6, 2018
@josesimoes josesimoes merged commit 5ff3bb5 into nanoframework:develop Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double.ToString() and float.ToString() not working as described
3 participants