Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Appveyor build options for ESP32 #843

Merged
merged 7 commits into from
Sep 6, 2018
Merged

Fix Appveyor build options for ESP32 #843

merged 7 commits into from
Sep 6, 2018

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Sep 6, 2018

Description

The appveyor build on Network branch didn't include the latest WiFi code.
Fixed and sorted out rest of options for all build types.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Sep 6, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better with these!

try switching wifi off
try switch off the correct one this time
Remove header files
comment out denug message
Revert previous chnages
@josesimoes josesimoes merged commit 121d377 into nanoframework:develop Sep 6, 2018
@AdrianSoundy AdrianSoundy deleted the WiFi-auto-build branch September 6, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants