Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #409: NativeToDouble doesn't support the "e"/"E" exponential char #850

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Fix for issue #409: NativeToDouble doesn't support the "e"/"E" exponential char #850

merged 1 commit into from
Sep 10, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

Description

Implemented the "e" and "E" sign in the paring algorithm in NativeToDouble

Motivation and Context

How Has This Been Tested?

Convert.ToDouble("4711E+81") return now the correct value of 4.744E+84 and Convert.ToDouble("-81.5E-47") return now the correct value of -8.15E-46

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

@MatthiasJentsch
Fix for issue #409: NativeToDouble doesn't support the "e"/"E" expone…
09c51ef 
…ntial char

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
@nfbot
Copy link
Member

nfbot commented Sep 10, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Sep 10, 2018
josesimoes
josesimoes approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here! 💯

@MatthiasJentsch MatthiasJentsch merged commit 2d13012 into nanoframework:develop Sep 10, 2018
@MatthiasJentsch MatthiasJentsch deleted the Fix409 branch September 10, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NativeToDouble doesn't support the "e"/"E" exponential char
3 participants
@MatthiasJentsch @nfbot @josesimoes