Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #390: object.GetHashCode not working #852

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Fix for issue #390: object.GetHashCode not working #852

merged 2 commits into from
Sep 12, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

@MatthiasJentsch MatthiasJentsch commented Sep 11, 2018

Description

I've improved the GetHashCode method and return the CRC32 of the heap block address if the instance has no fields.

Motivation and Context

How Has This Been Tested?

object a = new object();
object b = new object();
object c = a;
int ha = a.GetHashCode();
int hb = b.GetHashCode();
int hc = c.GetHashCode();

With the code changes ha, hb and hc are no longer zero and ha equals hc because that's the same object.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

I've improved the GetHashCode method and return the CRC32 of the heap block address if the instance has no fields.

Signed-off-by: Matthias Jentsch <info@matthias-jentsch.de>
@nfbot
Copy link
Member

nfbot commented Sep 11, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@MatthiasJentsch MatthiasJentsch merged commit ddc507e into nanoframework:develop Sep 12, 2018
@MatthiasJentsch MatthiasJentsch deleted the Fix390 branch September 12, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Status: DONE Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object.GetHashCode not working
3 participants