Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete parameter BOARD_NAME #861

Merged
merged 2 commits into from
Sep 18, 2018
Merged

remove obsolete parameter BOARD_NAME #861

merged 2 commits into from
Sep 18, 2018

Conversation

doingnz
Copy link
Contributor

@doingnz doingnz commented Sep 18, 2018 •
edited by josesimoes
Loading

BOARD_NAME parameter was removed when the install-tools.ps1 script was made ESP32 specific. This PR fixes a missing edit.

Description

Only text change BUILD_ESP32.md

Motivation and Context

Correction to documentation

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Fix documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: DoingNZ doingnz@gmail.com

@nfbot
Copy link
Member

nfbot commented Sep 18, 2018

Hi @doingnz,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes
josesimoes approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit 6293e31 into nanoframework:develop Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doingnz @nfbot @josesimoes