Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on config block #904

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Work on config block #904

merged 2 commits into from
Oct 9, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Fix handling of NF_FEATURE_HAS_CONFIG_BLOCK: the CMake option wasn't being properly handled in order to pass the expected value into the corresponding compiler define.
  • Configuration manager now handles the creation of a default block: not all targets are able to create a default block, code now is able to cope with that situation

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- The CMake option wasn't being properly handled in order to pass the expected value into the corresponding compiler define

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Not all targets are able to create a default block, code now is able to cope with that situation

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Oct 9, 2018
@nfbot
Copy link
Member

nfbot commented Oct 9, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 9f8e66f into nanoframework:develop Oct 9, 2018
@josesimoes josesimoes deleted the fix-420 branch October 9, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants