Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with infinite timeout handling #906

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

josesimoes
Copy link
Member

Description

  • The timeout infinite handling was incomplete because C# constant System.Threading.Timeout.Infinite is -1, but in milliseconds. The native code expectes a value in ticks, so it was considered invalid.

Motivation and Context

How Has This Been Tested?

  • Serial sample, scenario 4. The same as the developer mentioned in the issue.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Oct 11, 2018
@nfbot
Copy link
Member

nfbot commented Oct 11, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample SerialCommunication bug report
2 participants