Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move System.Math to it's own class lib #948

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Move System.Math to it's own class lib #948

merged 1 commit into from
Oct 26, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Rework System.Math to System.MathInternal to keep abs, max and min (int args only)
  • Update mscorlib assembly declarations
  • Add System.Math assembly declarations
  • Update CMakes accordingly
  • Update cmake.varianats with new build option
  • Update STM32 build definitions enabling system.math for all targets, except STM32F091

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Oct 26, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the work-426 branch 6 times, most recently from 828bb04 to eda1c72 Compare October 26, 2018 12:07
@josesimoes
Move System.Math to it's own class lib
fa7ebdf 
- Rework System.Math to System.MathInternal to keep abs, max and min (int args only)
- Update mscorlib assembly declarations
- Add System.Math assembly declarations
- Update CMakes accordingly
- Update cmake.varianats with new build option
- Update STM32 build definitions enabling system.math for all targets, except STM32F091
- Update ESP32 build definitions enabling system.math

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit 42c4846 into nanoframework:develop Oct 26, 2018
@josesimoes josesimoes deleted the work-426 branch October 26, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract System.Math to become an independent class lib
2 participants
@josesimoes @nfbot