Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket changes and fixes for HTTP #955

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Socket changes and fixes for HTTP #955

merged 2 commits into from
Nov 7, 2018

Conversation

AdrianSoundy
Copy link
Member

Description

Add support for Socket Linger, otherwise we get internal exceptions in Http requests.
Updated ESP32 IDF version in target_board_in to correct value.
Fix issue with ESP32 where sockets are not closed properly causing ESP32 to run out of sockets.

Motivation and Context

Fix issues when testing HTTP lib.

How Has This Been Tested?

To test ran Browser with automatic requests every 1 second.
Each request resulted in requests for favicon.ico and the main html page.
Ran test for 1 day with over 47000 request, ESP32 ran without any errors.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundyadriansoundy@gmail.com

Add support for Socket Linger otherwise we get internal exceptionhs in Http
UPdate ESP32 IDF version in target_board_in to correct value
Fix issue with ESP32 where sockets are not closed properly causing ESP32 to run out of sockets.
@nfbot
Copy link
Member

nfbot commented Nov 6, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done. 👏

@josesimoes josesimoes merged commit 0dc1e7d into nanoframework:develop Nov 7, 2018
@josesimoes josesimoes changed the title Socket fixes for Http Socket changes and fixes for HTTP Nov 7, 2018
@AdrianSoundy AdrianSoundy deleted the develop-socket-fixes branch November 8, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants