Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native implementation for 1-Wire class library #987

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

sjmneves
Copy link
Contributor

Description

  • Only for STM32 targets. Still missing ESP32 implementation.

Motivation and Context

How Has This Been Tested?

  • 1-Wire test app in samples repo.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Sérgio Nevessergio.neves@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Nov 14, 2018

Hi @sjmneves,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Nov 14, 2018
@josesimoes josesimoes force-pushed the work-428 branch 8 times, most recently from 2211041 to c054699 Compare November 15, 2018 11:21
@josesimoes josesimoes merged commit bc636fd into nanoframework:develop Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants