Allow efac/log10_tneqad to be None in ndiag functions #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In white_signals.py, the
*_ndiag
functions fail if they get passedNone
values. This happens, for example, if thewhite_noise_block
inenterprise_extensions has
vary=False
, and therefore efac/equad/ecorr are set toConstant
parameters, which have default values of None.The two potential fixes are the one in this PR, i.e., allow
None
values, which forefac_ndiag
is equivalent to havingefac=1.0
, and settneqad_ndiag
to zeros if passedNone. The other fix would be to specify values for the
Constantsin the
white_noise_block` inenterprise_extensions, e.g.,: