Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] New QUIC multistreams #1076

Merged
merged 92 commits into from
Oct 28, 2024
Merged

[WIP] New QUIC multistreams #1076

merged 92 commits into from
Oct 28, 2024
+1,598 −2,003

Conversation

wanghaEMQ
Copy link
Member

No description provided.

wanghaEMQ added 30 commits October 2, 2024 05:10
@wanghaEMQ
* NEW [proto/quic] Remove multistream codes and commented codes in qu…
f500b1f 
…ic protocol layer.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [proto/quic] Rename quic_mqtt_pipe interfaces to mqtt_quic_pipe
686cd63 
.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [proto/quic] Clean the codes.
46d892d 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Add extension quic connection struct.
e0a7f09 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Open multiple streams when quic connected.
23686a7 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Update the way to open multiple streams.
2c9c319 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Add method to close substream (which should not effect m…
ce11789 
…ain stream or dialer).

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Support to use new extension quic connection to send and…
59b154d 
… recv.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Support to close quic sub streams.
80871c3 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] No effect to quic connection or dialer when a sub stream…
111a4e4 
… closed.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix the missing stream interfaces.
afa24ca 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Add streamId to logs.
9cdaac6 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix some warnings in compiling.
6fcef99 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix some error in logs.
586729b 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Add quic_substream_close to close a quic substream.
a200980 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Support to free a extension quic connection.
b9c679b 
* FIX [quic] Remove the lock in extension connection.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Close all sub streams when main stream is closing.
4881d32 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Free extension connection when main stream is finite.
ba437d6 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix the nng stream xxx in quic stream layer.
93ca381 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Send quic msg in round robin.
26b0ade 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix the heap use after free when quic connection open fa…
25e3a21 
…iled.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Update the msquic_strm_open method.
b240ef0 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Only the main stream has ref cnt2. one for peer close an…
d9dfca2 
…d one for app close.

* NEW [quic] QUIC sub streams will be reopen when peer close.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Add lock guard for ex_quic_conn->substrms.
85e04ac 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix the reopen logic.:
db01417 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix the wrong index of stream.
413b43c 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] reconnectaio should be put to inside of nni_quic_conn.
2016cd5 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Split quic_substream_free and quic_substream_rele.
124dcb4 
quic_substream_free is used to free a nni_quic_conn when ref == 0.
quic_substream_rele is used to close and free a msquic stream without free nni_quic_conn.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* NEW [quic] Stop quic reconnect aio when nng_stream_free is called.
930b88c 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Error code in aio should be NNG_ECANCEL instead of NNG_E…
13ec518 
…CONSHUT.

Signed-off-by: wanghaemq <wangwei@emqx.io>
wanghaEMQ and others added 23 commits October 23, 2024 20:21
@wanghaEMQ
* FIX [quic] Fix the leaks of quic fds.
8921e5b 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Fix the unused interface warning in building.
5e87b6b 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
* FIX [quic] Finish aio for returning a result to trans layer althoug…
daa5541 
…h the aio begin failed.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@JaylinYu
* MDF [mqtt_quic/protocol] remove ack aio
a4aa985 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* MDF [mqtt_quic/protocol] remove TODOs
7dc736f 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* MDF [mqtt_quic/protocol] correct a wrong API name
a335f21 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* FIX [mqtt_quic/quic_dial] multiple bug fixes of quic dialer!
52c32a5 
Signed-off-by: jaylin <jaylin@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [quic] Fix the fds leaks thats leak caused by aio stop.
1209d8e 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [quic] Not finish aios when aio begin failed.
69c8409 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@JaylinYu
* MDF [mqtt/quic] enhance errocode passing between different layers
7e39462 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* MDF [MQTT/QUIC] change log level
809f47d 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* FIX [mqtt_quic] move lmq finit to pipe finit
4082d30 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* FIX [msquic_dial] fix a fd leaking issue caused by main stream cancel
c8a1f44 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* FIX [msquic_dial] a tmp fix of stop reopenning stream when main str…
85de05c 
…eam closed

Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* MDF [mqtt_quic] use correct return code
a3aeb86 
Signed-off-by: jaylin <jaylin@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [quic] Fix the return code of aio for substream.
4f32429 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [quic] Clean the codes.
48c4c8b 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [proto/quic] set busy to false when aio send failed.
3e5c978 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@JaylinYu
* FIX [mqtt_quic_client] set correct pipe busy state
ab4bdeb 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* FIX [mqtt_quic_client] stop receving when got specific err code
53392ee 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* MDF [mqtt_quic] close connection if main stream got closed
b5b374c 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* FIX [msquic_dial] fix quic stream open racing
aa743e2 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu
* MDF [mqtt_quic] modify logging level
4c0631f 
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu JaylinYu marked this pull request as ready for review October 28, 2024 01:23
@wanghaEMQ @JaylinYu
* FIX [quic] Clean the codes.
6adf3f5 
Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [quic] Fix the wrong place to set QUIC_STREAM_START_FLAG_SHUTDO…
4982527 
…WN_ON_FAIL.

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ @JaylinYu
* FIX [proto/quic] Fix the wrong reason code setting and warnings in …
6105ecb 
…building.

* FIX [trans/quic] Fix the warnings in transport layer.

Signed-off-by: wanghaemq <wangwei@emqx.io>
JaylinYu
JaylinYu approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a huge PR, Now multi-stream of MQTT over QUIC is finally arrived!

@JaylinYu JaylinYu merged commit 75b655e into main Oct 28, 2024
13 of 15 checks passed
@JaylinYu JaylinYu deleted the multistream-dev branch October 28, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaylinYu JaylinYu JaylinYu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanghaEMQ @JaylinYu