Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regrading shared subscription and wildcards #1883

Closed
Terry-Wang1 opened this issue Aug 30, 2024 · 5 comments
Closed

Regrading shared subscription and wildcards #1883

Terry-Wang1 opened this issue Aug 30, 2024 · 5 comments
Labels

Comments

@Terry-Wang1
Copy link

Terry-Wang1 commented Aug 30, 2024

I deploy a NanoMQ as our MQTT broker. Since the server may have multiple instances. We try to use the MQTT v5.0's feature "shared subscription". The question is happened when we try to subscribe a topic "$share/1/terrafuse/sports/#". Whenever I use the $share and wildcard, it will prompt "protocol error" and disconnect and connect again and again. But if only use one of them, it's totally fine. I think this topic should be valid, but NanoMQ doesn't support that, could you help me to fix that problem? or do you have the alternative option?

@Terry-Wang1
Copy link
Author

Terry-Wang1 commented Aug 30, 2024

I read the code and found that you check that if there is wildcard after $share, it will return protocol error. But I don't know why implement it like this
image

JaylinYu added a commit that referenced this issue Sep 4, 2024
@JaylinYu
Copy link
Member

JaylinYu commented Sep 4, 2024

Ok, it is a bug; I was trying to eliminate the wildcard in share-name...
I have fixed it in #1888

@JaylinYu JaylinYu added the bug label Sep 4, 2024
@Terry-Wang1
Copy link
Author

Good to hear that you have fixed it. Looks like the merge to master branch wasn't successful. One more question, if it merged successfully, does the docker image in docker hub will update too? Since I see the last time you update the docker image is 2 years ago.

@JaylinYu
Copy link
Member

JaylinYu commented Sep 4, 2024

Good to hear that you have fixed it. Looks like the merge to master branch wasn't successful. One more question, if it merged successfully, does the docker image in docker hub will update too? Since I see the last time you update the docker image is 2 years ago.

You gonna need to pull a new docker image, by this context would be NanoMQ 0.22.8. It will be updated automatically Once I finalize the release.

The last docker ver is released only 2 weeks ago. Plz verify you are pulling from correct path.

JaylinYu added a commit that referenced this issue Sep 4, 2024
@Terry-Wang1
Copy link
Author

Hi Jay, I think the bug is fixed. Thank your support again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants