Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple security issue fix #1867

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Multiple security issue fix #1867

merged 5 commits into from
Aug 12, 2024

Conversation

JaylinYu
Copy link
Member

No description provided.

Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
Signed-off-by: jaylin <jaylin@emqx.io>
@JaylinYu JaylinYu requested a review from wanghaEMQ August 12, 2024 07:39
}
// nng_msg_set_proto_data(rmsg, NULL, proto_data);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@@ -291,6 +291,7 @@ bridge_pub_handler(nano_work *work)
} else {
nng_aio_set_timeout(node->bridge_aio[index], 3000);
nng_aio_set_msg(node->bridge_aio[index], bridge_msg);
// switch to nng_ctx_send!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for cancel?

nng_msg_set_cmd_type(rmsg,CMD_PUBLISH_V5);
nng_msg *rmsg = NULL;
if (nng_msg_dup(&rmsg, work->msg) != 0) {
log_error("System Failure while duplicating retain msg");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more action?

@JaylinYu JaylinYu merged commit f73d24f into master Aug 12, 2024
86 of 89 checks passed
@JaylinYu JaylinYu deleted the jaylin/dev branch August 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants