-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved dependency management from govendor to dep #41
base: master
Are you sure you want to change the base?
Moved dependency management from govendor to dep #41
Conversation
after encountering some challenges while trying to add `go.etcd.io/etcd`, I decided to to dep.
I think some test previously ghosted because govendor returned with code 0 even for failed tests while go test doesn't so the tests won't pass until we install a postgres agent om which to make test like it was done with consul. |
I think this here will do https://docs.travis-ci.com/user/database-setup/#postgresql |
This is shaping up! I don't think we want to do |
I had first to bump the go version to |
However I am going to try and add redis before I try etcd which is more complex, then after I ahve understood the whole codebase I can try etcd |
after encountering some challenges while trying to add
go.etcd.io/etcd
,I decided to move from govendor (dep)[https://github.com/golang/dep] after having consulted with the etcd project (etcd-io/etcd#10288 (comment)) and realizing the issue was with the dependency manager. Then after I was asked to open a PR (#39 (comment))