Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swapped variables in write_all_browser_files() (#1) #336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SycamoreLeaf
Copy link
Contributor

Variables fasta_fn and motif_descs are passed between three functions as follows:

_browser_files_main() --> write_all_browser_files() --> write_frac_wigs()

The two variables were swapped at both interfaces.


_browser_files_main() --> write_all_browser_files():

write_all_browser_files(
args.fast5_basedirs, args.control_fast5_basedirs, args.corrected_group,
args.basecall_subgroups, args.statistics_filename,
args.browser_file_basename, args.file_types, args.genome_fasta,
args.motif_descriptions)

def write_all_browser_files(
fast5s_dirs, ctrl_fast5s_dirs, corr_grp, bc_subgrps,
stats_fn, wig_base, wig_types, motif_descs, fasta_fn):

write_all_browser_files() --> write_frac_wigs():

write_frac_wigs(
all_stats, wig_base, FRAC_WIG_TYPE in wig_types,
DFRAC_WIG_TYPE in wig_types, STAT_WIG_TYPE in wig_types,
VCOV_WIG_TYPE in wig_types, motif_descs, fasta_fn)

def write_frac_wigs(
all_stats, wig_base, do_frac, do_damp, do_stats, do_vcov, fasta_fn,
motif_descs):

Variables `fasta_fn` and `motif_descs` are passed between three functions as follows:
_browser_files_main() --> write_all_browser_files() --> write_frac_wigs()
The two variables were swapped at both interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant