Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fetching context of private posts #139

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

AndrewKvalheim
Copy link
Contributor

From my timeline FediFetcher is repeatedly attempting to access private posts:

2024-07-01 17:16:27.362 PDT: Error getting context for toot https://example.com/@example/xxxxxxxxxxxxxxxx. Status code: 404
2024-07-01 17:16:37.445 PDT: Error getting context for toot https://example.com/@example/xxxxxxxxxxxxxxxx. Status code: 404
2024-07-01 17:16:44.915 PDT: Error getting context for toot https://example.com/@example/xxxxxxxxxxxxxxxx. Status code: 404
2024-07-01 17:16:51.760 PDT: Error getting context for toot https://example.com/@example/xxxxxxxxxxxxxxxx. Status code: 404

This will never succeed, so better to skip those requests.

Context fetching is performed without authentication, so it is only
possible for public and unlisted posts.
@nanos
Copy link
Owner

nanos commented Jul 2, 2024

Nice one! Thank you!

@nanos nanos merged commit d863b58 into nanos:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants