Check for directory type on open and read syscalls #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux does not allow normal read or write to directory file descriptors, so open should return EISDIR for any write access and read should return EISDIR if the descriptor is a directory. The write runtime test has been updated to verify this behavior. This change also defines O_DIRECTORY which should return ENOTDIR if the specified file is not a directory. See open(2) and read(2) for further description of these behaviors.
sanderssj
force-pushed
the
fix/open-write-directory
branch
from
1e56407 to
95a58b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux does not allow normal read or write to directory file descriptors,
so open should return EISDIR for any write access and read should return
EISDIR if the descriptor is a directory. The write runtime test has been
updated to verify this behavior. This change also defines O_DIRECTORY
which should return ENOTDIR if the specified file is not a directory.
See open(2) and read(2) for further description of these behaviors.
Fixes #1533