E2E tests: ruby: remove sinatra gem install and GEM_HOME env var #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ruby_3.1.2 package already includes the sinatra gem, thus it is not necessary to install it locally in order to run a Ruby web server. This change removes the sinatra gem installation step in the Rubty e2e test; in addition, the GEM_HOME environment variable is being removed from the Ops configuration file because the Ruby package already provides a correct value for this variable (consistent with the contents of the package). This change fixes a 'Sinatra could not start, the "rackup" gem was not found' error that occurs when trying to run the (locally installed) latest release of the sinatra gem during the e2e tests.
eyberg
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ruby_3.1.2 package already includes the sinatra gem, thus it is not necessary to install it locally in order to run a Ruby web server. This change removes the sinatra gem installation step in the Rubty e2e test; in addition, the GEM_HOME environment variable is being removed from the Ops configuration file because the Ruby package already provides a correct value for this variable (consistent with the contents of the package).
This change fixes a 'Sinatra could not start, the "rackup" gem was not found' error that occurs when trying to run the (locally installed) latest release of the sinatra gem during the e2e tests.