Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nishikawa/kisa_io/#71 #95

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Nishikawa/kisa_io/#71 #95

merged 9 commits into from
Apr 22, 2021

Conversation

KaoruNishikawa
Copy link
Contributor

This PR resolves #67 by converting structured array into xr.DataArrays. The implementation almost automagically resolved #72. A bit of additional code also resolved #71.

@KaoruNishikawa KaoruNishikawa added the enhancement New feature or request label Apr 22, 2021
Copy link
Member

@r-yamada1998 r-yamada1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-yamada1998 r-yamada1998 merged commit 1966de4 into main Apr 22, 2021
@KaoruNishikawa KaoruNishikawa deleted the nishikawa/kisa_io/#71 branch April 22, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants