Skip to content

Commit

Permalink
Fix scopes on auth when app/run images are on different registries
Browse files Browse the repository at this point in the history
This bumps the github.com/google/go-containerregistry dependency so
that a fix for supporting app and run images on from different
registries is pulled in.

In particular, google/go-containerregistry#604
is the fix. Previously, when the app and run image are on different
registries, the app image registry would be asked for the pull scope
of the run image which will fail since it's not present.

Signed-off-by: Nan Zhong <nan@notanumber.io>
  • Loading branch information
nanzhong committed Mar 11, 2020
1 parent 9ae7545 commit 296971b
Show file tree
Hide file tree
Showing 41 changed files with 1,943 additions and 259 deletions.
3 changes: 1 addition & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ require (
github.com/docker/go-connections v0.4.0
github.com/golang/mock v1.3.1
github.com/google/go-cmp v0.3.0
github.com/google/go-containerregistry v0.0.0-20191018211754-b77a90c667af
github.com/google/go-containerregistry v0.0.0-20200304201134-fcc8ea80e26f
github.com/heroku/color v0.0.6
github.com/mattn/go-colorable v0.1.4 // indirect
github.com/mattn/go-isatty v0.0.10 // indirect
github.com/pkg/errors v0.8.1
github.com/sclevine/spec v1.4.0
golang.org/x/net v0.0.0-20190724013045-ca1201d0de80 // indirect
golang.org/x/sync v0.0.0-20190423024810-112230192c58
golang.org/x/sys v0.0.0-20191010194322-b09406accb47
google.golang.org/genproto v0.0.0-20190508193815-b515fa19cec8 // indirect
Expand Down
267 changes: 265 additions & 2 deletions go.sum

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions vendor/github.com/gogo/protobuf/proto/extensions.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions vendor/github.com/gogo/protobuf/proto/extensions_gogo.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

242 changes: 242 additions & 0 deletions vendor/github.com/google/go-containerregistry/pkg/authn/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions vendor/github.com/google/go-containerregistry/pkg/v1/image.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 296971b

Please sign in to comment.