Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functions.dart #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update functions.dart #101

wants to merge 5 commits into from

Conversation

Mahfa
Copy link

@Mahfa Mahfa commented Sep 18, 2023

fix RTL issue

fix RTL issue
@clragon
Copy link
Contributor

clragon commented Nov 6, 2023

Could you explain which issue exactly?
Is there a reason we are adding this Directionality in the screenLock callback instead of inside the ScreenLock widget where we would only need to add it once?

@Mahfa
Copy link
Author

Mahfa commented Nov 6, 2023

@clragon
the issue is when the locale of the material app is set to a rtl locale like "fa" or "ps" the layout of the lock screen is wrong.

Is there a reason we are adding this Directionality in the screenLock callback instead of inside the ScreenLock widget where we would only need to add it once?

no there is not i just added it there for simplicity

@clragon
Copy link
Contributor

clragon commented Nov 6, 2023

Okay, awesome thank you.
Could you in that case move the Directionality widget inside of the ScreenLock widget?
That would be beneficial, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants