Fix docs #136
Merged
Fix docs #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naomijub
reviewed
Mar 22, 2021
naomijub
reviewed
Mar 22, 2021
| - `<=` means lesser or equal, so if `a <= 100`, this means that the entity map key `a` must be lesser or equals to `100`. | ||
| - `>` means greater, so if `a > 100`, this means that the entity map key `a` must be greater than `100`. | ||
| - `<` means lesser, so if `a < 100`, this means that the entity map key `a` must be lesser than `100`. | ||
| - `==` means equals, so if `a == 100`, this means that the entity map key `a` must equal to `100`. |
There was a problem hiding this comment.
Again, equals is equivalent to the verb, so a must equals to x is correct, and I prefer. While this change was correct != means not equal, so if a != 100 because it refers to the mathematics operation.
There was a problem hiding this comment.
It shouldn't have the s because the equality is being referred to the key, which is singular.
I think the equals in the beginning of the sentence is the one that describes what you've said correctly, that's why it has the s.
There was a problem hiding this comment.
but it is the subject and not the mathematical operation
naomijub
reviewed
Mar 22, 2021
naomijub
reviewed
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the other chapters, tell me what do ya think 🙂
Next pull request should be code only 👨💻