Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support 0.40 #26

Merged
merged 4 commits into from
Feb 9, 2017
Merged

Conversation

mlabrum
Copy link
Contributor

@mlabrum mlabrum commented Jan 18, 2017

Hey,

I've made the changes that RN 0.40 requires, and I've also upgraded the example project to 0.40

Thanks

@gcarling
Copy link

@naoufal Can you please merge this? We rely on this in our project and would really love to be able to keep using it past RN-0.40. Thank you!

@ThisIsMissEm
Copy link

ThisIsMissEm commented Jan 24, 2017

Can I point you to: https://medium.com/@thisismissem/how-to-upgrade-react-native-modules-in-a-backwards-compatible-manner-a5b5c48d590c

It's a way to do this in a backwards compatible manner.

@g3r4n
Copy link

g3r4n commented Jan 26, 2017

I've make it backwards compatible in #27

@g3r4n
Copy link

g3r4n commented Jan 30, 2017

Please merge this one because It's preferable to not backwards compatible module, in order to always support the last version of RN. previous version will support RN<0.40

@g3r4n
Copy link

g3r4n commented Jan 30, 2017

@mlabrum can you update the Readme with the version that support RN <0.40.0 and update the package.json ?

@u0x01
Copy link

u0x01 commented Feb 7, 2017

pleaseeeee merge this pr, we need it! @naoufal

@naoufal naoufal merged commit 46cf6c2 into naoufal:master Feb 9, 2017
@naoufal
Copy link
Owner

naoufal commented Feb 9, 2017

@u0x01 @g3r4n @ThisIsMissEm @gcarling @mlabrum merged and published to npm under 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants