Skip to content
This repository has been archived by the owner on Nov 24, 2024. It is now read-only.

this file shouldn't be empty, so I added the missing part #6

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

lkthomas
Copy link
Contributor

No description provided.

@M0NsTeRRR M0NsTeRRR added the 🐛 bug Something isn't working label Sep 29, 2022
@M0NsTeRRR
Copy link
Collaborator

Linked to #5

@M0NsTeRRR M0NsTeRRR linked an issue Oct 11, 2022 that may be closed by this pull request
@M0NsTeRRR
Copy link
Collaborator

M0NsTeRRR commented Oct 11, 2022

@lkthomas have you seen my review ? waiting for your change to merge the PR
Don't forget to run pre-commit (check readme) to fix black issue

@lkthomas
Copy link
Contributor Author

done, please check

@M0NsTeRRR
Copy link
Collaborator

@lkthomas you need to add the fix i've writed in the review, uncomment the import you did in the last commit and run pre-commit to fix file formatting.

Or if you prefer you can give me the permission to edit your PR (you have to check a box in your PR to allow mantainer to edit it)

@lkthomas
Copy link
Contributor Author

"Allow edits by maintainers" is always checked

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@M0NsTeRRR M0NsTeRRR merged commit 172d57e into napalm-automation-community:main Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

library can't call from Napalm
2 participants