Change listener to be plugable #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-orden
force-pushed
the
plugable_listener
branch
from
2a8f164 to
9cfdc05
Compare
napalm_logs/listener/kafka.py
Outdated
| signal.signal(signal.SIGTERM, self._exit_gracefully) | ||
| self.__up = True | ||
| try: | ||
| self.consumer = kafka.KafkaConsumer(bootstrap_servers='{}:{}'.format(self.address, self.port), group_id='napalm-logs') |
There was a problem hiding this comment.
This indentation doesn't look fine. Can you check?
Also, when passing multiple kwargs, please separate them on new lines.
napalm_logs/listener/kafka.py
Outdated
| self.consumer = kafka.KafkaConsumer(bootstrap_servers='{}:{}'.format(self.address, self.port), group_id='napalm-logs') | ||
| except kafka.errors.NoBrokersAvailable as err: | ||
| log.error(err, exc_info=True) | ||
| raise NapalmLogsException(err) |
There was a problem hiding this comment.
Maybe we should introduce a new exception class for listener.
napalm_logs/listener/tcp.py
Outdated
| ''' | ||
| signal.signal(signal.SIGTERM, self._exit_gracefully) |
There was a problem hiding this comment.
Looks like unidented block.
napalm_logs/listener/udp.py
Outdated
| ''' | ||
| Start listening for messages | ||
| ''' | ||
| signal.signal(signal.SIGTERM, self._exit_gracefully) |
napalm_logs/listener/udp.py
Outdated
| except socket.error as msg: | ||
| error_string = 'Unable to bind to port {} on {}: {}'.format(self.port, self.address, msg) | ||
| log.error(error_string, exc_info=True) | ||
| raise BindException(error_string) |
There was a problem hiding this comment.
If we introduce a new exception class, don't forger to raise it here too.
mirceaulinic
requested changes
Jun 13, 2017
napalm_logs/transport/base.py
Outdated
| @@ -14,8 +14,5 @@ def __init__(self, addr, port): | |||
| def start(self): | |||
| pass | |||
|
|
|||
| def publish(self, obj): | |||
There was a problem hiding this comment.
Added back, this was unintended
luke-orden
force-pushed
the
plugable_listener
branch
from
9cfdc05 to
4574a4e
Compare
I have changed the listener to be plugable in the same way that the publisher transport is. I have also added a kafka listener too.
luke-orden
force-pushed
the
plugable_listener
branch
from
4574a4e to
7a806b8
Compare
mirceaulinic
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the listener to be plugable in the same way that the
publisher transport is.
I have also added a kafka listener too.