Fix EOS get_arp_table for static ARP records #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewing
reviewed
Aug 18, 2020
napalm/eos/eos.py
Outdated
| @@ -966,7 +966,7 @@ def get_arp_table(self, vrf=""): | |||
| interface = str(neighbor.get("interface")) | |||
| mac_raw = neighbor.get("hwAddress") | |||
| ip = str(neighbor.get("address")) | |||
| age = float(neighbor.get("age")) | |||
| age = float(neighbor.get("age", 0.0)) | |||
There was a problem hiding this comment.
Should we use -1.0 to mark static entries? I notice nxos uses this approach, but IOS doesn't. Perhaps worth standardizing on?
There was a problem hiding this comment.
I would vote for -1.0 for all OSes, as looks like "-1" is a standard value for N/A in Napalm.
There was a problem hiding this comment.
Agreed. @praniq - please feel free to update this branch, then I can merge it.
There was a problem hiding this comment.
Updated EOS, IOS and IOS XR. Please have a look. Thanks
…device didn't return any value. Usually for static ARP entries or local IPs. NX-OS already does this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For static ARP entries EOS eAPI gives records without "age" key. Therefore NAPALM throws an exception in get_arp_table during:
age = float(neighbor.get('age'))Fixing this bug.