Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_vlans getter to EOS network driver #1279

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Add get_vlans getter to EOS network driver #1279

merged 2 commits into from
Aug 28, 2020

Conversation

yzguy
Copy link
Contributor

@yzguy yzguy commented Aug 26, 2020

This would add the get_vlans() getter to the EOS network driver, which is currently not supported for the platform

@yzguy yzguy changed the title Eos get vlans Add get_vlans getter to EOS network driver Aug 26, 2020
@coveralls
Copy link

coveralls commented Aug 26, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 91ecccb on yzguy:eos_get_vlans into bfb9484 on napalm-automation:develop.

@yzguy yzguy marked this pull request as ready for review August 26, 2020 05:38
@yzguy
Copy link
Contributor Author

yzguy commented Aug 26, 2020

Not sure if there are any more tests to add for this new addition, there was a pass on

test/eos/test_getters.py::TestGetter::test_get_vlans[normal] PASSED

@mirceaulinic mirceaulinic added this to the 3.2.0 milestone Aug 26, 2020
@mirceaulinic
Copy link
Member

Yep, that's all it needs @yzguy - looking good! Just a small Black formatting issue: https://travis-ci.org/github/napalm-automation/napalm/jobs/721233843#L228, then we should be ready to get this in. (To correct that issue, in your environment, just run black . and commit the changes).

mirceaulinic
mirceaulinic approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this addition @yzguy! I'll include this in the next release 3.2.0, scheduled to go out early next week.

@mirceaulinic mirceaulinic merged commit 88d50ee into napalm-automation:develop Aug 28, 2020
@yzguy yzguy deleted the eos_get_vlans branch August 28, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
eos get_vlans method implementation
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yzguy @coveralls @mirceaulinic