-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nxos ssh get interfaces counters #1287
Feature/nxos ssh get interfaces counters #1287
Conversation
54c2701
to
fa5b17c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just please make sure the tests are passing, then we should be gtg.
napalm/nxos_ssh/nxos_ssh.py
Outdated
|
||
return all_stats_d | ||
|
||
# print(counters_table_raw) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
napalm/nxos_ssh/nxos_ssh.py
Outdated
'rx_broadcast_packets': int, | ||
""" | ||
if_mapping = { | ||
'eth': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Black doesn't like this, can you upgrade to the latest version then run black .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirceaulinic Thanks for the review.
I fix it asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirceaulinic Fixes on their way with latest push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @ExaneServerTeam!
=Implements nxos_ssh get_interfaces_counters=