Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping for Juniper devices with Netmiko #1288

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix mapping for Juniper devices with Netmiko #1288

merged 1 commit into from
Sep 8, 2020

Conversation

vincentbernat
Copy link
Contributor

junos was incorrectly mapped to juniper_eos instead of
juniper_junos. It shouldn't matter much as, AFAIK, junos is not
using Netmiko.

@vincentbernat
Fix mapping for Juniper devices with Netmiko
ac0964f 
`junos` was incorrectly mapped to `juniper_eos` instead of
`juniper_junos`. It shouldn't matter much as, AFAIK, `junos` is not
using Netmiko.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling ac0964f on vincentbernat:fix/netmiko-junos into 965966d on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling ac0964f on vincentbernat:fix/netmiko-junos into 965966d on napalm-automation:develop.

mirceaulinic
mirceaulinic approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentbernat

@mirceaulinic mirceaulinic added this to the 3.2.1 milestone Sep 8, 2020
@mirceaulinic mirceaulinic merged commit 23b9356 into napalm-automation:develop Sep 8, 2020
@mirceaulinic mirceaulinic modified the milestones: 3.2.1, 3.3.0 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentbernat @coveralls @mirceaulinic