Look up the KeepAliveTime and HoldTime keys in the VRF tree #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a copy-paste probably, the code is currently looking under the ``instance_active_list``, which as the name suggests is a list of XML trees, therefore any xpath query fails, with the following message. Thanks to the newly added logging on the ``find_txt`` helper, the following appeared in the logs: ``` 'list' object has no attribute 'xpath' 'list' object has no attribute 'xpath' 'list' object has no attribute 'xpath' 'list' object has no attribute 'xpath' 'list' object has no attribute 'xpath' 'list' object has no attribute 'xpath' ``` This corrects this, by referencing the actual XML tree for the VRF instead of the list of VRFs.
ktbyers
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a copy-paste probably, the code is currently looking under the
instance_active_list, which as the name suggests is a list of XMLtrees, therefore any xpath query fails, with the following message.
Thanks to the newly added logging on the
find_txthelper, thefollowing appeared in the logs:
This corrects this, by referencing the actual XML tree for the VRF
instead of the list of VRFs.