Set next hop to something valid for vxlan routes #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good @malanovo, I think your changes make sense. Would you also be able to add a test case for this? Thanks.
|
Sure, I can work on that. I've got several devices I can pull from for an example. |
|
Test case has been added. Please note that the test case relies on the fix for issue #1069 having been applied (which was just recently merged into the |
mirceaulinic
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change that stops Napalm from bombing out on EOS when attempting a get_route_to() on a VXLAN route, and inserts some values that make it useful. The next hop is set to the IP of the destination VTEP, and the exit interface is set to vxlan1. Granted we're assuming the interface name will be vxlan1, but at the moment, that's all it can be on EOS. It might need alteration in the future if Arista changes that.