Handle control plane interface #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceaulinic
requested changes
Mar 26, 2021
Co-authored-by: Mircea Ulinic <mirceaulinic@users.noreply.github.com>
|
Thanks, @mirceaulinic I was wondering what was failing the CI. Looking better now. |
mirceaulinic
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1410
I approached the fix by simply adding an additional regex pattern for the interface line. There are multiple approaches that are a matter of opinion, e.g. just modify existing pattern with an or to include the text but I chose this route.
Also a matter of opinion is whether to handle this case and return the data or just skip it and exclude from the response as it seems to just be a bogus interface with no MAC, MTU, etc; however, I assume let the user handle that decision and just return the data as it is on the device which I think is inline with NAPALM principles.
Tests should also work to cover this case.