-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hinting #1476
Type hinting #1476
Conversation
Anything else I can do here to help get this merged? |
Yeah, don't hold this up for me...so if it is good with @mirceaulinic (then it is fine with me). |
Hi @Kircheneer. Yes, just let me release version 3.4.0 (hopefully next week), then we can merge this and start preparing release 4.0.0. Sorry for the wait! |
Thanks @mirceaulinic. Just let me know whenever we are ready for merging, then I'll clean up the conflicting files again. |
Left with the following errors:
For the first one: The docs state explicitly that a For the second one: I'm unsure how this got introduced - any pointers? |
Regarding the def commit_config(self, message: str = "", revert_in: Optional[int] = None) -> None:
raise napalm.CommitError("Pending commit confirm already in process!")
count = self._count_calls("commit_config")
self._raise_if_closed()
if revert_in is not None:
if self.has_pending_commit():
raise napalm.CommitError("Pending commit confirm already in process!")
else:
self._pending_commits = True
self.merge = None
self.filename = None
self.config = None
mocked_data(self.path, "commit_config", count) This lead to the following unit test errors:
I'll put in a fix for that into this branch if you don't mind. About the other issue I think we need to have a synchronous discussion because that touches lots of places at once. |
…e checking for nxapi_plumbing
…e checking for nxapi_plumbing
Bumps [pytest-pythonpath](https://github.com/bigsassy/pytest-pythonpath) from 0.7.3 to 0.7.4. - [Release notes](https://github.com/bigsassy/pytest-pythonpath/releases) - [Commits](https://github.com/bigsassy/pytest-pythonpath/commits) --- updated-dependencies: - dependency-name: pytest-pythonpath dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
- Fix wrong import path for napalm.base.exceptions.CommitError - Re-write convert method to properly utilize typing
31434ed
to
92119dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @Kircheneer! 🙇🏼
Something weird happened with #1434 so I redid the PR - again. This should be mostly free of any non-sense commits and should reflect a proper and useful implementation of type hinting for the NXOS parts of NAPALM.