Disable InsecureRequestWarning if ssl_verify is false in nxos driver #1510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see many examples where NAPALM users utilizing the nxos driver are doing something like this in their code to work around cert warnings that are displayed:
One example blog post
This is well and fine but I believe that the intent of the
ssl_verify
optional_arg for the nxos driver is that we should not verify the certificate in addition to hiding anyInsecureRequestWarning
warnings that are displayed. This change disablesInsecureRequestWarning
whenssl_verify
is false or none which is the default for this driver.An explicit example setting
ssl_verify=False
(implicit by default) with the current master branch:With my proposed changes: