iss-1416 #1573
iss-1416 #1573
Conversation
emfusion
commented
Feb 21, 2022
emfusion
commented
- fix get_bgp_neighbors_detail() when using multi-agent mode
- fix issue where multihop var was wrongly interpreted as it was comparing 0 with ‘0’
- Add IPv6 prefixes to the advertised and received prefix count
- Add more test for get_bgp_neighbors_detail
Move the multi-agent check from the open() (globally set) to the get_bgp_neighbors_detail() function (locally set). Update the bgp_detail_multi_agent textfsm template to: - Fix issue where the connection_state and local_address were sometimes missing - Use a newline as a separator for each record Fix issue where multihop var was wrongly interpreted as it was comparing 0 with ‘0’ Add IPv6 prefixes to the advertised and received prefix count. Update the testcase and bgp_detail.tpl textfsm template to support this Add more test for get_bgp_neighbors_detail
emfusion
force-pushed
the
wip-1416-add-multiagent-support
branch
from
db8f00f to
32389c0
Compare
Co-authored-by: Mircea Ulinic <mirceaulinic@users.noreply.github.com>
removed typo ")"
removed unused variable
|
Little late the the party here, apologies. Are the two output formats so different we can't use a single template? Recognizing the start of the next record should allow one to close out the previous record -- this approach is used in the VRF template: https://github.com/napalm-automation/napalm/blob/develop/napalm/eos/utils/textfsm_templates/vrf.tpl#L7 Removing the
as the first regexp might allow us to use a single template, if the rest of the output is similar enough? We would need to specify at least one required variable, so that empty records aren't recorded. |
|
@emfusion have you had a chance to look at Brandon's suggestion above? This still LGTM otherwise... |
|
Merged as-is, but feel free to follow up with another PR and we shall review! 😄 |
Hi, I unfortunately havent had the time to look into it (forgot how time consuming newborns are 😆). It's on my To Do list and will definitely jump into it soon |
