eos: support arbitrary transport class #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewing
force-pushed
the
eos_arbitrary_transport
branch
from
71c3b51 to
7222c18
Compare
Allow passing of a subclass of EapiConnection as the transport, either as a class object or a string that can be imported as a class.
bewing
force-pushed
the
eos_arbitrary_transport
branch
from
7222c18 to
defc367
Compare
bewing
added a commit
that referenced
this pull request
May 24, 2022
In conjunction with #1643, if an arbitrary transport class is stateful, we should be trying to maintain state (exiting config mode after entering, closing when closing, etc).
Merged
bewing
added a commit
that referenced
this pull request
May 24, 2022
In conjunction with #1643, if an arbitrary transport class is stateful, we should be trying to maintain state (exiting config mode after entering, closing when closing, etc).
bewing
added a commit
that referenced
this pull request
May 24, 2022
In conjunction with #1643, if an arbitrary transport class is stateful, we should be trying to maintain state (exiting config mode after entering, closing when closing, etc).
mirceaulinic
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing of a subclass of EapiConnection as the transport, either
as a class object or a string that can be imported as a class.