Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving iosxr get_facts behavior to handle XML changes in newer OS versions #1667

Merged
merged 8 commits into from
Jul 11, 2022

Conversation

ktbyers
Copy link
Contributor

@ktbyers ktbyers commented Jun 9, 2022

No description provided.

@ktbyers
Copy link
Contributor Author

ktbyers commented Jun 9, 2022

@Kani999 So this only fixed get_facts() it doesn't fix anything else.

Can you see if this works on your failing device?

@ktbyers
Copy link
Contributor Author

ktbyers commented Jun 9, 2022

@Kani999 What issue did you run into with the get_interfaces call and are you still running into it with this updated code here?

@Kani999
Copy link
Contributor

Kani999 commented Jun 10, 2022

@Kani999 What issue did you run into with the get_interfaces call and are you still running into it with this updated code here?

#1668 There are changes for get_interfaces() method, which works with IOS-XR 7.3.3
I have to look at the rest of the methods and find out all the problems.

@ktbyers
Copy link
Contributor Author

ktbyers commented Jun 10, 2022

Okay, I will try to incorporate the get_interfaces() fixes (since get_facts() calls get_interfaces()).

Have you tried using the iosxr_netconf driver in NAPALM (i.e. does that driver work properly with your 7.3.3 code)?

@Kani999
Copy link
Contributor

Kani999 commented Jun 14, 2022

Okay, I will try to incorporate the get_interfaces() fixes (since get_facts() calls get_interfaces()).

Have you tried using the iosxr_netconf driver in NAPALM (i.e. does that driver work properly with your 7.3.3 code)?

iosxr_netconf works fine except get_environment. Which does not work with XML too.

I'm looking at the get_environment method to get it to work via XML calls, but with no luck. Other supported methods, should be working with the changes.

@mirceaulinic mirceaulinic merged commit ef8326c into develop Jul 11, 2022
@mirceaulinic mirceaulinic deleted the xr_getfacts branch July 11, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants