-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Junos: Do not try to parse a "none" value and convert it to "" for get_ipv6_neighbors_table #1983
Junos: Do not try to parse a "none" value and convert it to "" for get_ipv6_neighbors_table #1983
Conversation
Failing test is not related to my changes. |
Hi @bewing , |
Last working build
failing build
Guessing we have a new linting rule in pycodestyle 2.11 |
@jsenecal can you leave the "normal" test as-is and create a new folder with a new test in it (named iss1978 or similar), with its own inputs and expected result? |
This reverts commit aba8cdf.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, but otherwise LGTM
test/junos/mocked_data/test_get_ipv6_neighbors_table/mac_is_none/expected_result.json
Outdated
Show resolved
Hide resolved
test/junos/mocked_data/test_get_ipv6_neighbors_table/mac_is_none/get-ipv6-nd-information.xml
Outdated
Show resolved
Hide resolved
Thanks for your contribution! |
Fixes #1978